I got this to work actually doing this:
pass in break end proto icmp icmp-type echo
I have to let the ping IN before the router can answer it.
This was the only line I had to add to make it work. Since I only enable the FW on the ppp1 interface, I can leave that part of it out.